fix(lite): use UiPanelCard in VDI side panel cards - #10317
Draft
ByScripts wants to merge 1 commit into
Draft
Conversation
VdiConfigurationCard and VdiInfosCard used UiCard, whose 2.4rem padding is meant for page cards, and re-declared UiPanelCard's 1.6rem gap locally. They now match the spacing of every other side panel card.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
VdiConfigurationCardandVdiInfosCardnow useUiPanelCardinstead ofUiCard, like every other side panel card.UiCardcarries a 2.4rem paddingmeant for page cards. The local
gaprule they declared duplicated oneUiPanelCardalready provides, and is dropped.Introduced by #10269
Checklist
Fixes #007,See xoa-support#42,See https://...)Introduced byCHANGELOG.unreleased.mdReview process
If you are an external contributor, you can skip this part. Simply create the pull request, and we'll get back to you as soon as possible.
Notes: