Skip to content

fix(lite): use UiPanelCard in VDI side panel cards - #10317

Draft
ByScripts wants to merge 1 commit into
web-core/add-ui-panel-card-titlefrom
lite/fix-vdi-panel-card-spacing
Draft

fix(lite): use UiPanelCard in VDI side panel cards#10317
ByScripts wants to merge 1 commit into
web-core/add-ui-panel-card-titlefrom
lite/fix-vdi-panel-card-spacing

Conversation

@ByScripts

Copy link
Copy Markdown
Contributor

⚠️ Wait for #10289

Description

VdiConfigurationCard and VdiInfosCard now use UiPanelCard instead of
UiCard, like every other side panel card. UiCard carries a 2.4rem padding
meant for page cards. The local gap rule they declared duplicated one
UiPanelCard already provides, and is dropped.

Introduced by #10269

Checklist

  • Commit
    • Title follows commit conventions
    • Reference the relevant issue (Fixes #007, See xoa-support#42, See https://...)
    • If bug fix, add Introduced by
  • Changelog
    • If visible by XOA users, add changelog entry
    • Update "Packages to release" in CHANGELOG.unreleased.md
  • PR
    • If UI changes, add screenshots
    • If not finished or not tested, open as Draft

Review process

If you are an external contributor, you can skip this part. Simply create the pull request, and we'll get back to you as soon as possible.

This 2-passes review process aims to:

  • develop skills of junior reviewers
  • limit the workload for senior reviewers
  • limit the number of unnecessary changes by the author
  1. The author creates a PR.
  2. Review process:
    1. The author assigns the junior reviewer.
    2. The junior reviewer conducts their review:
      • Resolves their comments if they are addressed.
      • Adds comments if necessary or approves the PR.
    3. The junior reviewer assigns the senior reviewer.
    4. The senior reviewer conducts their review:
      • If there are no unresolved comments on the PR → merge.
      • Otherwise, we continue with 3.
  3. The author responds to comments and/or makes corrections, and we go back to 2.

Notes:

  1. The author can request a review at any time, even if the PR is still a Draft.
  2. In theory, there should not be more than one reviewer at a time.
  3. The author should not make any changes:
    • When a reviewer is assigned.
    • Between the junior and senior reviews.
  4. If the PR relates to a change in the openAPI specification, a member of the DevOps team must also participate in the review.

VdiConfigurationCard and VdiInfosCard used UiCard, whose 2.4rem padding
is meant for page cards, and re-declared UiPanelCard's 1.6rem gap
locally. They now match the spacing of every other side panel card.
@ByScripts ByScripts self-assigned this Aug 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant