Skip to content

feat(web-core): add ignoreRoute option to table pagination and query builder filter - #10476

Merged
OlivierFL merged 1 commit into
masterfrom
web-core/table-ignore-route
Oct 12, 2026
Merged

OlivierFL merged 1 commit into
masterfrom
web-core/table-ignore-route

Conversation

@ByScripts

Copy link
Copy Markdown
Contributor

Description

usePagination and useQueryBuilderFilter accept a new ignoreRoute option. When set, the pagination start index and the query builder filter are kept in memory instead of the URL, so a table displayed in an overlay does not change the page URL.

The pagination doc also states the right "Show by" default (24 instead of 50).

const { pageRecords, paginationBindings } = usePagination('items', items, { ignoreRoute: true })

const { items: filteredItems, filter } = useQueryBuilderFilter('items', items, { ignoreRoute: true })

See XO-3099.

Checklist

  • Commit
    • Title follows commit conventions
    • Reference the relevant issue (Fixes #007, See xoa-support#42, See https://...)
    • If bug fix, add Introduced by
  • Changelog
    • If visible by XOA users, add changelog entry
    • Update "Packages to release" in CHANGELOG.unreleased.md
  • PR
    • If UI changes, add screenshots
    • If not finished or not tested, open as Draft

Review process

If you are an external contributor, you can skip this part. Simply create the pull request, and we'll get back to you as soon as possible.

This 2-passes review process aims to:

  • develop skills of junior reviewers
  • limit the workload for senior reviewers
  • limit the number of unnecessary changes by the author
  1. The author creates a PR.
  2. Review process:
    1. The author assigns the junior reviewer.
    2. The junior reviewer conducts their review:
      • Resolves their comments if they are addressed.
      • Adds comments if necessary or approves the PR.
    3. The junior reviewer assigns the senior reviewer.
    4. The senior reviewer conducts their review:
      • If there are no unresolved comments on the PR → merge.
      • Otherwise, we continue with 3.
  3. The author responds to comments and/or makes corrections, and we go back to 2.

Notes:

  1. The author can request a review at any time, even if the PR is still a Draft.
  2. In theory, there should not be more than one reviewer at a time.
  3. The author should not make any changes:
    • When a reviewer is assigned.
    • Between the junior and senior reviews.
  4. If the PR relates to a change in the openAPI specification, a member of the DevOps team must also participate in the review.

@ByScripts ByScripts self-assigned this Sep 29, 2026
@plane-sync-vates

Copy link
Copy Markdown

Linked to Plane Work Item(s)

This comment was auto-generated by Plane

@sandrine-bd
sandrine-bd requested a review from J0ris-K October 2, 2026 10:43
…y builder filter

`usePagination` and `useQueryBuilderFilter` always store their state in the
route query. A table displayed in an overlay must not change the URL of the
page behind it, so both composables now accept `ignoreRoute` to keep that
state in memory instead.

The pagination doc also states the right "Show by" default (24, not 50).

See XO-3099
@ByScripts
ByScripts force-pushed the web-core/table-ignore-route branch from a7fa43b to 6d4aada Compare October 12, 2026 07:19
@OlivierFL
OlivierFL merged commit 641f988 into master Oct 12, 2026
2 checks passed
@OlivierFL
OlivierFL deleted the web-core/table-ignore-route branch October 12, 2026 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants