Skip to content

feat(web-core): add checkbox column to host, SR and VM column sets - #10485

Merged
OlivierFL merged 1 commit into
masterfrom
web-core/add-checkbox-column
Oct 12, 2026
Merged

OlivierFL merged 1 commit into
masterfrom
web-core/add-checkbox-column

Conversation

@ByScripts

Copy link
Copy Markdown
Contributor

Description

Adds a checkbox column to the host, SR and VM column sets. It is mainly meant for the upcoming role creation, where users will select the hosts, SRs and VMs a privilege applies to. Existing tables in web and lite exclude it, so their display is unchanged.

Checklist

  • Commit
    • Title follows commit conventions
    • Reference the relevant issue (Fixes #007, See xoa-support#42, See https://...)
    • If bug fix, add Introduced by
  • Changelog
    • If visible by XOA users, add changelog entry
    • Update "Packages to release" in CHANGELOG.unreleased.md
  • PR
    • If UI changes, add screenshots
    • If not finished or not tested, open as Draft

Review process

If you are an external contributor, you can skip this part. Simply create the pull request, and we'll get back to you as soon as possible.

This 2-passes review process aims to:

  • develop skills of junior reviewers
  • limit the workload for senior reviewers
  • limit the number of unnecessary changes by the author
  1. The author creates a PR.
  2. Review process:
    1. The author assigns the junior reviewer.
    2. The junior reviewer conducts their review:
      • Resolves their comments if they are addressed.
      • Adds comments if necessary or approves the PR.
    3. The junior reviewer assigns the senior reviewer.
    4. The senior reviewer conducts their review:
      • If there are no unresolved comments on the PR → merge.
      • Otherwise, we continue with 3.
  3. The author responds to comments and/or makes corrections, and we go back to 2.

Notes:

  1. The author can request a review at any time, even if the PR is still a Draft.
  2. In theory, there should not be more than one reviewer at a time.
  3. The author should not make any changes:
    • When a reviewer is assigned.
    • Between the junior and senior reviews.
  4. If the PR relates to a change in the openAPI specification, a member of the DevOps team must also participate in the review.

Allow host, SR and VM tables to offer row selection, for future usage.
Existing tables in web and lite exclude the column, so their display is
unchanged.
@ByScripts
ByScripts force-pushed the web-core/add-checkbox-column branch from ca3210d to 965acbf Compare October 12, 2026 07:19
@OlivierFL
OlivierFL merged commit 1b1ae50 into master Oct 12, 2026
2 checks passed
@OlivierFL
OlivierFL deleted the web-core/add-checkbox-column branch October 12, 2026 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants