Skip to content

feat(backups): improve full mirror backup performances - #10537

Merged
b-Nollet merged 6 commits into
masterfrom
feat_full_mirror_perf
Oct 9, 2026
Merged

b-Nollet merged 6 commits into
masterfrom
feat_full_mirror_perf

Conversation

@fbeauchamp

@fbeauchamp fbeauchamp commented Oct 6, 2026 •

Copy link
Copy Markdown
Collaborator

Description

implements XO-3135 and XO-3134

checksum computation cost become visible above 300MB/s, and can saturate a CPU if not accelerated before 500.

a full backup is typically a (5-100 )GB, default hightwatermark means reading it through 64KB blocks

on my setup

  • master : 450MB/s
  • this branch : 1400MB/s
image

cpu usage went from 2.28s of cpu usage per GB to 0.90

Checklist

  • Commit
    • Title follows commit conventions
    • Reference the relevant issue (Fixes #007, See xoa-support#42, See https://...)
    • If bug fix, add Introduced by
  • Changelog
    • If visible by XOA users, add changelog entry
    • Update "Packages to release" in CHANGELOG.unreleased.md
  • PR
    • If UI changes, add screenshots
    • If not finished or not tested, open as Draft

Review process

If you are an external contributor, you can skip this part. Simply create the pull request, and we'll get back to you as soon as possible.

This 2-passes review process aims to:

  • develop skills of junior reviewers
  • limit the workload for senior reviewers
  • limit the number of unnecessary changes by the author
  1. The author creates a PR.
  2. Review process:
    1. The author assigns the junior reviewer.
    2. The junior reviewer conducts their review:
      • Resolves their comments if they are addressed.
      • Adds comments if necessary or approves the PR.
    3. The junior reviewer assigns the senior reviewer.
    4. The senior reviewer conducts their review:
      • If there are no unresolved comments on the PR → merge.
      • Otherwise, we continue with 3.
  3. The author responds to comments and/or makes corrections, and we go back to 2.

Notes:

  1. The author can request a review at any time, even if the PR is still a Draft.
  2. In theory, there should not be more than one reviewer at a time.
  3. The author should not make any changes:
    • When a reviewer is assigned.
    • Between the junior and senior reviews.
  4. If the PR relates to a change in the openAPI specification, a member of the DevOps team must also participate in the review.

@plane-sync-vates

plane-sync-vates Bot commented Oct 6, 2026 •

Copy link
Copy Markdown

Linked to Plane Work Item(s)

References

This comment was auto-generated by Plane

@fbeauchamp
fbeauchamp marked this pull request as ready for review October 6, 2026 11:52
@fbeauchamp fbeauchamp changed the title Feat full mirror perf feat(backups): improve full mirror backup performances Oct 6, 2026
Comment thread @xen-orchestra/backups/_runners/_vmRunners/FullRemote.mjs Outdated
@b-Nollet
b-Nollet merged commit 70b0824 into master Oct 9, 2026
2 of 3 checks passed
@b-Nollet
b-Nollet deleted the feat_full_mirror_perf branch October 9, 2026 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants