Skip to content

Conversation

fbeauchamp
Copy link
Collaborator

@fbeauchamp fbeauchamp commented Sep 9, 2025

Description

Most of the test has been ported to node-test , the remaining few are on a code path that should be removed as soon as the ova import/export is ported to XO6

this won't trigger a packet release , since it won't change their behavior

Checklist

  • Commit
    • Title follows commit conventions
    • Reference the relevant issue (Fixes #007, See xoa-support#42, See https://...)
    • If bug fix, add Introduced by
  • Changelog
    • If visible by XOA users, add changelog entry
    • Update "Packages to release" in CHANGELOG.unreleased.md
  • PR
    • If UI changes, add screenshots
    • If not finished or not tested, open as Draft

Review process

If you are an external contributor, you can skip this part. Simply create the pull request, and we'll get back to you as soon as possible.

This 2-passes review process aims to:

  • develop skills of junior reviewers
  • limit the workload for senior reviewers
  • limit the number of unnecessary changes by the author
  1. The author creates a PR.
  2. Review process:
    1. The author assigns the junior reviewer.
    2. The junior reviewer conducts their review:
      • Resolves their comments if they are addressed.
      • Adds comments if necessary or approves the PR.
    3. The junior reviewer assigns the senior reviewer.
    4. The senior reviewer conducts their review:
      • If there are no unresolved comments on the PR → merge.
      • Otherwise, we continue with 3.
  3. The author responds to comments and/or makes corrections, and we go back to 2.

Notes:

  1. The author can request a review at any time, even if the PR is still a Draft.
  2. In theory, there should not be more than one reviewer at a time.
  3. The author should not make any changes:
    • When a reviewer is assigned.
    • Between the junior and senior reviews.

@fbeauchamp fbeauchamp marked this pull request as ready for review September 23, 2025 07:23
@fbeauchamp fbeauchamp requested a review from mpiton September 23, 2025 07:24
@mpiton mpiton requested a review from MathieuRA September 24, 2025 07:08
Copy link
Member

@MathieuRA MathieuRA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ran a yarn command again and I get a differential of 31 lines in the yarn.lock file. Is this expected?

List of commands:

debian@XOA-from-source:~/xen-orchestra$ git checkout chore_remove_jest
Switched to branch 'chore_remove_jest'
Your branch is up to date with 'origin/chore_remove_jest'.

// get master yarn.lock
debian@XOA-from-source:~/xen-orchestra$ git checkout master yarn.lock
Updated 1 path from f6ba7aa45

debian@XOA-from-source:~/xen-orchestra$ yarn
...

// compare the yarn.lock to your branch
debian@XOA-from-source:~/xen-orchestra$ git diff --stat chore_remove_jest yarn.lock
 yarn.lock | 31 ++++++++++++++++++++++++++++---
 1 file changed, 28 insertions(+), 3 deletions(-)

fbeauchamp and others added 3 commits October 16, 2025 11:08
jest test are unmaintained and flacky, they increase the dependencies surface
@fbeauchamp
Copy link
Collaborator Author

I ran a yarn command again and I get a differential of 31 lines in the yarn.lock file. Is this expected?

List of commands:

debian@XOA-from-source:~/xen-orchestra$ git checkout chore_remove_jest
Switched to branch 'chore_remove_jest'
Your branch is up to date with 'origin/chore_remove_jest'.

// get master yarn.lock
debian@XOA-from-source:~/xen-orchestra$ git checkout master yarn.lock
Updated 1 path from f6ba7aa45

debian@XOA-from-source:~/xen-orchestra$ yarn
...

// compare the yarn.lock to your branch
debian@XOA-from-source:~/xen-orchestra$ git diff --stat chore_remove_jest yarn.lock
 yarn.lock | 31 ++++++++++++++++++++++++++++---
 1 file changed, 28 insertions(+), 3 deletions(-)

now this should be ok

@fbeauchamp fbeauchamp requested a review from MathieuRA October 16, 2025 11:09
@MathieuRA MathieuRA merged commit 87df162 into master Oct 17, 2025
1 of 2 checks passed
@MathieuRA MathieuRA deleted the chore_remove_jest branch October 17, 2025 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants