Skip to content

Conversation

fbeauchamp
Copy link
Collaborator

@fbeauchamp fbeauchamp commented Oct 3, 2025

Description

Some feature have been removed while movinf to generator, this PR reimplement them

  • speed limit on full backup
  • timeout on Xapi read
  • speed limit on incremental backup/replication / mirror backup

Review by commit

Checklist

  • Commit
    • Title follows commit conventions
    • Reference the relevant issue (Fixes #007, See xoa-support#42, See https://...)
    • If bug fix, add Introduced by
  • Changelog
    • If visible by XOA users, add changelog entry
    • Update "Packages to release" in CHANGELOG.unreleased.md
  • PR
    • If UI changes, add screenshots
    • If not finished or not tested, open as Draft

Review process

If you are an external contributor, you can skip this part. Simply create the pull request, and we'll get back to you as soon as possible.

This 2-passes review process aims to:

  • develop skills of junior reviewers
  • limit the workload for senior reviewers
  • limit the number of unnecessary changes by the author
  1. The author creates a PR.
  2. Review process:
    1. The author assigns the junior reviewer.
    2. The junior reviewer conducts their review:
      • Resolves their comments if they are addressed.
      • Adds comments if necessary or approves the PR.
    3. The junior reviewer assigns the senior reviewer.
    4. The senior reviewer conducts their review:
      • If there are no unresolved comments on the PR → merge.
      • Otherwise, we continue with 3.
  3. The author responds to comments and/or makes corrections, and we go back to 2.

Notes:

  1. The author can request a review at any time, even if the PR is still a Draft.
  2. In theory, there should not be more than one reviewer at a time.
  3. The author should not make any changes:
    • When a reviewer is assigned.
    • Between the junior and senior reviews.

@fbeauchamp fbeauchamp force-pushed the feat_timeout_rate_limit branch 5 times, most recently from fe998b5 to dc8251c Compare October 6, 2025 12:35
@fbeauchamp fbeauchamp requested a review from b-Nollet October 6, 2025 12:36
@fbeauchamp fbeauchamp requested a review from b-Nollet October 15, 2025 09:08
@b-Nollet b-Nollet force-pushed the feat_timeout_rate_limit branch from 4449b5f to dc8251c Compare October 16, 2025 09:04
@b-Nollet b-Nollet force-pushed the feat_timeout_rate_limit branch from dc8251c to 8a3fd18 Compare October 16, 2025 09:16
@b-Nollet b-Nollet force-pushed the feat_timeout_rate_limit branch from 8a3fd18 to 1f9c24a Compare October 16, 2025 09:24
@b-Nollet b-Nollet merged commit 596f9ac into master Oct 16, 2025
1 check passed
@b-Nollet b-Nollet deleted the feat_timeout_rate_limit branch October 16, 2025 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants