Skip to content

Conversation

fbeauchamp
Copy link
Collaborator

@fbeauchamp fbeauchamp commented Oct 15, 2025

Description

from ticket 40151

Checklist

  • Commit
    • Title follows commit conventions
    • Reference the relevant issue (Fixes #007, See xoa-support#42, See https://...)
    • If bug fix, add Introduced by
  • Changelog
    • If visible by XOA users, add changelog entry
    • Update "Packages to release" in CHANGELOG.unreleased.md
  • PR
    • If UI changes, add screenshots
    • If not finished or not tested, open as Draft

Review process

If you are an external contributor, you can skip this part. Simply create the pull request, and we'll get back to you as soon as possible.

This 2-passes review process aims to:

  • develop skills of junior reviewers
  • limit the workload for senior reviewers
  • limit the number of unnecessary changes by the author
  1. The author creates a PR.
  2. Review process:
    1. The author assigns the junior reviewer.
    2. The junior reviewer conducts their review:
      • Resolves their comments if they are addressed.
      • Adds comments if necessary or approves the PR.
    3. The junior reviewer assigns the senior reviewer.
    4. The senior reviewer conducts their review:
      • If there are no unresolved comments on the PR → merge.
      • Otherwise, we continue with 3.
  3. The author responds to comments and/or makes corrections, and we go back to 2.

Notes:

  1. The author can request a review at any time, even if the PR is still a Draft.
  2. In theory, there should not be more than one reviewer at a time.
  3. The author should not make any changes:
    • When a reviewer is assigned.
    • Between the junior and senior reviews.

@fbeauchamp fbeauchamp force-pushed the fix_replication_unmanaged branch from 62f11fa to fdfc486 Compare October 15, 2025 15:05
@fbeauchamp fbeauchamp marked this pull request as ready for review October 15, 2025 15:23
@fbeauchamp fbeauchamp requested a review from mpiton October 15, 2025 15:23
@mpiton mpiton requested a review from b-Nollet October 15, 2025 18:11
Copy link
Collaborator

@b-Nollet b-Nollet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this really a new functionality (as the PR title suggests)? It looks like a fix

@fbeauchamp fbeauchamp changed the title feat(backups): throw an error on non unique target for replication fix(backups): throw an error on non unique target for replication Oct 16, 2025
@fbeauchamp fbeauchamp force-pushed the fix_replication_unmanaged branch from 45b731f to e01044c Compare October 16, 2025 11:04
@fbeauchamp fbeauchamp requested a review from b-Nollet October 16, 2025 11:05
@b-Nollet b-Nollet merged commit 8b3b23e into master Oct 16, 2025
1 check passed
@b-Nollet b-Nollet deleted the fix_replication_unmanaged branch October 16, 2025 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants