Skip to content

feat(xo-web): add merge synchronously option to mirror backups #9118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

feat(xo-web): add merge synchronously option to mirror backups #9118

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
055a9ce
feat(xo-web): show merge synchronously settings for mirror
fbeauchamp Oct 16, 2025
5b0a6ef
feat(xo-web): add merge synchronously option to mirror backups
fbeauchamp Oct 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions packages/xo-web/src/xo-app/backup/new/mirror/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -237,6 +237,8 @@ const NewMirrorBackup = decorate([
onChangeVmBackups: (_, vmBackups) => () => ({
vmsToMirror: vmBackups.map(({ value: vmUuid }) => vmUuid),
}),
setMergeBackupsSynchronously: ({ setAdvancedSettings }, mergeBackupsSynchronously) =>
setAdvancedSettings({ mergeBackupsSynchronously }),
},
computed: {
vmBackupOptions: async state => {
Expand Down Expand Up @@ -317,6 +319,7 @@ const NewMirrorBackup = decorate([
backupReportTpl = 'mjml',
hideSuccessfulItems,
nRetriesVmBackupFailures = 0,
mergeBackupsSynchronously,
} = state.advancedSettings
return (
<form id={state.formId}>
Expand Down Expand Up @@ -458,6 +461,21 @@ const NewMirrorBackup = decorate([
onChange={effects.setHideSuccessfulItems}
/>
</FormGroup>
<FormGroup>
<label htmlFor={state.inputMergeBackupsSynchronously}>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add a computed for inputMergeBackupsSynchronously.
inputMergeBackupsSynchronously: generateId

<strong>{_('mergeBackupsSynchronously')}</strong>
</label>{' '}
<Tooltip content={_('mergeBackupsSynchronouslyTooltip')}>
<Icon icon='info' />
</Tooltip>
<Toggle
className='pull-right'
id={state.inputMergeBackupsSynchronously}
name='mergeBackupsSynchronously'
value={mergeBackupsSynchronously}
onChange={effects.setMergeBackupsSynchronously}
/>
</FormGroup>
</div>
)}
</CardBlock>
Expand Down