Add mantine theme#1287
Draft
ErnestTeluk wants to merge 10 commits into
Draft
Conversation
github-actions
Bot
added
the
Area: Infra
wadamek65
reviewed
Oct 10, 2023
github-actions
Bot
added
the
Area: Docs
|
Was this abandoned? |
Contributor
Author
|
No, I will get back to it next week. We must wait for the bump |
piotrpospiech
requested changes
May 24, 2024
Collaborator
piotrpospiech
left a comment
piotrpospiech
left a comment
There was a problem hiding this comment.
- List items should be full width.
- Delete button in the
ListFieldhas weird position.
NestFieldlabel is<p>tag. We usually uselabelthere. Only in the material and MUI we used a different tag -legend.
piotrpospiech
requested changes
May 24, 2024
github-actions
Bot
added
Area: Theme
piotrpospiech
requested changes
Jun 16, 2024
| <Group mt="xs" align="flex-start" w="100%"> | ||
| {children} | ||
| <Box mt={20}> | ||
| <Box pos="absolute" right={0} top={10}> |
Collaborator
There was a problem hiding this comment.
Can those styles be moved to the ListDelField component? We can avoid additional nesting with Box.
|
|
||
| function ListItem({ | ||
| children = <AutoField label={null} name="" />, | ||
| children = <AutoField label={null} name="" style={{ width: '100%' }} />, |
Collaborator
There was a problem hiding this comment.
Did you test it with custom children? We don't want to pass width manually to every child component.
| return ( | ||
| <div {...filterDOMProps(props)}> | ||
| {label && <Text>{label}</Text>} | ||
| {label && <Label>{label}</Label>} |
Collaborator
There was a problem hiding this comment.
I think, it should be updated also in other fields e.g. RadioField.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.