fix: calculation for collapsing form is incorrect while initially hidden

[mynetfan]

• 修复当默认隐藏搜索表单时，折叠位置的计算不正确的问题

Summary by CodeRabbit

• Bug Fixes
  • Improved form rendering by ensuring row mapping is recalculated when the visibility of the expandable section changes, leading to more accurate layout updates.

[changeset-bot]

⚠️ No Changeset found

Latest commit: 53a0924

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[coderabbitai]

Walkthrough

The update integrates the useElementVisibility hook from @vueuse/core within the expandable form rendering logic. This hook monitors the visibility of a specific DOM element referenced by wrapperRef. The visibility state (isVisible) is now included as a dependency in the watcher that recalculates the row mapping, ensuring that recalculation occurs not only on changes to the collapse button, breakpoint, or schema length, but also when the wrapper's visibility changes. No changes were made to the function's signature or other exported entities.

Changes

File(s)	Change Summary
packages/@core/ui-kit/form-ui/src/form-render/expandable.ts	Added useElementVisibility hook to track wrapperRef visibility; included isVisible as a watcher dependency for recalculating row mapping. No changes to exported function signatures.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant UIComponent
    participant useElementVisibility
    participant Watcher

    User->>UIComponent: Interacts with form (show/hide, resize, etc.)
    UIComponent->>useElementVisibility: Tracks wrapperRef visibility
    useElementVisibility-->>UIComponent: Updates isVisible state
    UIComponent->>Watcher: Watcher observes [showCollapseButton, breakpoint, schema.length, isVisible]
    Watcher-->>UIComponent: Triggers row mapping recalculation on any dependency change

Loading

Suggested reviewers

• anncwb
• jinmao88
• vince292007

Poem

In the garden of forms where fields like to play,
A wrapper now whispers, “I’m visible today!”
With Vueuse in tow, we watch and we see,
When rows should be mapped, as clear as can be.
No signature changed, just logic refined—
The UI grows smarter, with visibility in mind!
🐇✨

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 681c1dc and 53a0924.

📒 Files selected for processing (1)

• packages/@core/ui-kit/form-ui/src/form-render/expandable.ts (2 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (8)

• GitHub Check: Test (windows-latest)
• GitHub Check: Lint (ubuntu-latest)
• GitHub Check: post-update (ubuntu-latest)
• GitHub Check: Check (ubuntu-latest)
• GitHub Check: Check (windows-latest)
• GitHub Check: Lint (windows-latest)
• GitHub Check: post-update (windows-latest)
• GitHub Check: Analyze (javascript-typescript)

🔇 Additional comments (3)

packages/@core/ui-kit/form-ui/src/form-render/expandable.ts (3)

5-9: Good use of @vueuse/core utilities.

The import block has been properly updated to include the useElementVisibility hook alongside existing imports from the same package.

---

16-16: Well implemented visibility tracking.

The useElementVisibility hook is appropriately used to track the visibility state of the wrapper element referenced by wrapperRef. This is a key part of the fix for the issue where calculations were incorrect when the form was initially hidden.

---

39-39: Good fix for hidden form calculation issues.

Adding isVisible.value as a dependency to the watch array ensures that row mapping recalculation occurs when the form's visibility changes. This directly addresses the issue where calculations were incorrect when the form was initially hidden.

The implementation correctly triggers recalculation when the visibility state changes, which will ensure proper layout even when the form starts in a hidden state.

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.