-
Notifications
You must be signed in to change notification settings - Fork 7.6k
fix: show validation message as tooltip in compact form #6087
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
WalkthroughThis change updates the form field error message display logic for the Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant FormField
participant VbenTooltip
participant CircleAlert
User->>FormField: Interacts with form in compact mode
FormField->>FormField: Validates input
alt Field is invalid and compact mode
FormField->>VbenTooltip: Render tooltip with FormMessage
VbenTooltip->>CircleAlert: Display alert icon as trigger
User->>CircleAlert: Hover/focus icon
VbenTooltip->>User: Show error message in tooltip
else Not compact or valid
FormField->>User: Show inline error message (if not compact)
end
Assessment against linked issues
Suggested reviewers
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (2)
⏰ Context from checks skipped due to timeout of 90000ms (7)
🔇 Additional comments (5)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
紧凑模式表单的校验消息将显示为一个tooltip
close: #5633
Summary by CodeRabbit