E2E Tests - #8
Merged
Merged
Conversation
Real-browser tests exercise behavior the mocked node:test suite cannot:
the forged-SDP ICE-TCP technique against real libwebrtc, and no-cors
fetch classification. Hermetic loopback servers provide known open,
open-silent, and closed targets; tests drive the published module via
page.evaluate and assert on returned ProbeResult JSON.
- e2e/: worker-scoped fixtures boot target + page servers; specs cover
fetch {open, open-silent, closed}, ICE {open, closed}, and scanPorts
orchestration (routing, restricted, order, progress).
- CI: new blocking e2e job installs Chromium and lowers the unprivileged
port floor so the <1024 fetch-route test runs; skips gracefully where
low ports can't bind (e.g. macOS).
- biome.json makes lint honor .gitignore so Playwright output isn't linted.
Chrome only; Firefox/WebKit are one-line project additions later.
Signed-off-by: v_c0d35 <vini.andrade.dev@gmail.com>
AbortSignal.timeout(t) can fire just before performance.now() measures t (Node truncates timer delays to whole ms and uses a slightly different clock), so `durationMs >= 50` failed intermittently on CI's slower clock. Allow a 5ms tolerance while still asserting the probe waited out the timeout rather than returning immediately. Behavior of the probe itself is unchanged.
vc0d35
force-pushed
the
e2e-chrome-ci
branch
from
September 1, 2026 13:01
5a5ccf8 to
ae4293a
Compare
The 'Introduce e2e tests' commit rewrote comments across the src files (verbose JSDoc to inline notes) with no logic changes. Restore the original comments as the baseline before applying a deliberate comment policy in the next commit.
Drop JSDoc/type boilerplate and comments that just restate the code. Keep concise notes only where the browser/libwebrtc behavior is non-obvious: the ICE requestsSent oracle, the < 1024 fetch routing, ICE-TCP check pacing, the CORP/ORB fetch false-negative, the restricted-port list, and the batch dedup. No code changes.
Signed-off-by: v_c0d35 <vini.andrade.dev@gmail.com>
vc0d35
force-pushed
the
e2e-chrome-ci
branch
from
September 2, 2026 17:25
5443362 to
7e42b61
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.