Remove dead RAYLIB/SOKOL #if blocks in Forms DialogBox#3546
Merged
Conversation
…padButton alias Neither RAYLIB nor SOKOL is ever defined in GumCommon's compile (the sole owner of this file) or in FRB's; RaylibGum and SokolGum both <Compile Remove> it and pull it in only via GumCommon. The two GamepadButton alias declarations collapse to one unconditional using, since every FRB-defining csproj also defines MONOGAME/FNA/KNI, so FRB always implies XNALIKE and the alias was already active in every real build configuration. Closes #3544 Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #3543's dead-
#ifreduction. Cleans upMonoGameGum/Forms/Controls/Games/DialogBox.csper-block, per #3544.Changes
#if RAYLIBand#if SOKOLusing-blocks — neither symbol is ever defined in GumCommon's compile (the sole owner of this file);RaylibGum.csprojandSokolGum.csprojboth<Compile Remove>this file and only pull it in via the GumCommon project reference. Confirmed dead everywhere.GamepadButtonalias declarations (#if !FRB && !XNALIKEand inside#if XNALIKE) into a single unconditionalusing GamepadButton = Gum.Input.GamepadButton;. Every FRB-defining csproj in the FlatRedBall repo also definesMONOGAME,FNA, orKNI(confirmed acrossFlatRedBall.Forms.DesktopGlNet6,.iOSMonoGame,.AndroidMonoGame,.FNA,.Kni.Web,.Kni.DesktopGL), soFRBalways impliesXNALIKEand the alias was already active in every real build configuration — the two declarations were never actually gated differently.#if FRB/#if XNALIKEbehavioral splits untouched (Tweener typewriter,IInputDeviceinput,TimeManager.CurrentTime, the XNA vsGum.Forms.InputKeysselection, etc.) per the issue's guidance.Verification
Behavior-preserving dead-code removal — no new test needed per the
tddskill's exemption. Verified via:dotnet build MonoGameGum.Tests/MonoGameGum.Tests.csproj— clean,DialogBoxTests15/15 passdotnet build Runtimes/RaylibGum/RaylibGum.csproj— cleandotnet build Runtimes/SkiaGum/SkiaGum.csproj— cleanFlatRedBall.Forms.DesktopGlNet6.csproj), built from the primary checkout: baseline (main) clean, branch clean, 0 new errorsCloses #3544
🤖 Generated with Claude Code