Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix syntax error #143

Merged
merged 2 commits into from
Feb 26, 2024
Merged

fix syntax error #143

merged 2 commits into from
Feb 26, 2024

Conversation

JavierMatosD
Copy link
Collaborator

In JavaScript, when you're inside an object literal, you don't need to use ${} to reference variables. This syntax is only needed inside template strings (strings enclosed in backticks ```).

head: ${newBranch},
base: "main"
head: newBranch,
base: "main"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't think you meant to add this trailing whitespace.

@JavierMatosD JavierMatosD merged commit 9130a5f into vcpkg:main Feb 26, 2024
1 check passed
@JavierMatosD JavierMatosD deleted the real_fix branch June 20, 2024 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants