Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix stars generation and update website #145

Merged
merged 11 commits into from
Mar 1, 2024

Conversation

JavierMatosD
Copy link
Collaborator

@JavierMatosD JavierMatosD commented Feb 29, 2024

This PR fixes the stars generation functionality by ensuring the GITHUB_TOKEN is available in the execution context. It also updates the site.

Copy link
Member

@ras0219-msft ras0219-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes look correct to me, though it would be cleaner for stars.json to be updated as part of syncMetadata.sh so that rebuild.sh can be fully deterministic.

@JavierMatosD JavierMatosD merged commit e992465 into vcpkg:main Mar 1, 2024
1 check passed
@JavierMatosD JavierMatosD deleted the fix_stars branch June 20, 2024 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants