Detailed package pages (New layout) #151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 12 commits
May 14, 2024 13:48
JavierMatosD
commented
May 14, 2024
| @@ -0,0 +1,30 @@ | |||
| document.addEventListener('DOMContentLoaded', function () { | |||
There was a problem hiding this comment.
I could name this package.jsto match the package.css and package.html but there is also packages.html, packages.css and packages.js The package(s) ones are for when you click on "Browse Packages" and it shows the list of packages.
I don't know what the convention is but it would be nice if the javascript files were named according to their function instead of who loads them.
ras0219-msft
approved these changes
May 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will implement the new layout described this spec.