Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detailed package pages (New layout) #151

Merged
merged 75 commits into from
May 30, 2024

Conversation

JavierMatosD
Copy link
Collaborator

This PR will implement the new layout described this spec.

@JavierMatosD JavierMatosD marked this pull request as ready for review May 6, 2024 12:55
@@ -0,0 +1,30 @@
document.addEventListener('DOMContentLoaded', function () {
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I could name this package.jsto match the package.css and package.html but there is also packages.html, packages.css and packages.js The package(s) ones are for when you click on "Browse Packages" and it shows the list of packages.

I don't know what the convention is but it would be nice if the javascript files were named according to their function instead of who loads them.

@JavierMatosD JavierMatosD requested a review from ras0219-msft May 24, 2024 15:25
@JavierMatosD JavierMatosD merged commit 4885674 into vcpkg:main May 30, 2024
1 check passed
@JavierMatosD JavierMatosD deleted the detailed_package_pages branch June 20, 2024 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants