-
Notifications
You must be signed in to change notification settings - Fork 92
[WIP] add values.go implementation #1770
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
c818af3 to
1772ccc
Compare
Deploying with
|
| Latest commit: |
7c0582e
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://dedbe9db.vald.pages.dev |
| Branch Preview URL: | https://feature-charts-valuesgo.vald.pages.dev |
|
[WARNING:INTCFG] Changes in |
1772ccc to
2dd4517
Compare
Signed-off-by: kpango <[email protected]>
2dd4517 to
7c0582e
Compare
|
|
||
| <a name="vald-v1-Filter"></a> | ||
|
|
||
| ### Filter |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Filter
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
|
|
||
| <a name="vald-v1-Insert"></a> | ||
|
|
||
| ### Insert |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Insert
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1770 +/- ##
==========================================
- Coverage 30.27% 28.03% -2.24%
==========================================
Files 373 348 -25
Lines 33713 32573 -1140
==========================================
- Hits 10207 9133 -1074
+ Misses 23113 23057 -56
+ Partials 393 383 -10 ☔ View full report in Codecov by Sentry. |
| ExternalTrafficPolicy string `json:"externalTrafficPolicy,omitempty"` | ||
| Hpa *Hpa `json:"hpa,omitempty"` | ||
| Image *Image `json:"image,omitempty"` | ||
| ExternalTrafficPolicy corev1.ServiceExternalTrafficPolicyType `json:"externalTrafficPolicy,omitempty"` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [golangci] reported by reviewdog 🐶
json(snake): got 'externalTrafficPolicy' want 'external_traffic_policy' (tagliatelle)
|
|
||
| // pod annotations | ||
| PodAnnotations *PodAnnotations `json:"podAnnotations,omitempty"` | ||
| PodAnnotations *Annotations `json:"podAnnotations,omitempty"` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [golangci] reported by reviewdog 🐶
json(snake): got 'podAnnotations' want 'pod_annotations' (tagliatelle)
9b3087a to
4a659f2
Compare
Signed-off-by: kpango [email protected]
Description:
Related Issue:
How Has This Been Tested?:
Environment:
Types of changes:
Changes to Core Features:
Checklist: