feat(webapp): surface full expected profit breakdown on signal page#123
Closed
itamarreif wants to merge 1 commit into
Closed
feat(webapp): surface full expected profit breakdown on signal page#123itamarreif wants to merge 1 commit into
itamarreif wants to merge 1 commit into
Conversation
The ExpectedProfitResponse already includes per-token USDC amounts and the prices used for conversion, but only the total was displayed. Now shows: - Surplus section: min USDC amount for each token (before summing to total), making the conversion from token surplus → USDC explicit - Config section: a "Prices Used" subsection with token_a/USDC, token_b/USDC, and ETH/USDC rates that were applied during signal generation No backend changes — all fields were already returned by the API. Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
Contributor
Author
|
Superseded by the full layout redesign in #122 — expected profit changes are included there. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
All
ExpectedProfitResponsefields were already returned by the API but only the total was shown. This PR exposes the remaining fields on the signal detail page:min_usdc_amount_a,min_usdc_amount_b) between each token surplus and the total, making the surplus → USDC conversion visibletoken_a/USDC,token_b/USDC, andETH/USDCrates applied during signal generationNo backend or DB changes — frontend only.
Test plan
🤖 Generated with Claude Code