Skip to content

Darren/feat/tx replacement #1008

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 6 commits into
base: old-release/galactica-3
Choose a base branch
from

Conversation

darrenvechain
Copy link
Member

@darrenvechain darrenvechain commented Mar 13, 2025

Description

Draft idea for replacing txs in the pool. Lots of TODOs and tidy up.

See tx_relpacement_test.go to see a working example

  • Concerns around nonce collision? Bytes32 instead of uint64 ?

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • New and existing E2E tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have not added any vulnerable dependencies to my code

@darrenvechain darrenvechain requested a review from a team as a code owner March 13, 2025 17:06
@darrenvechain darrenvechain marked this pull request as draft March 13, 2025 17:06
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 17.30769% with 129 lines in your changes missing coverage. Please review.

Project coverage is 61.84%. Comparing base (5e5f63d) to head (b914c08).

Files with missing lines Patch % Lines
txpool/tx_object_map.go 9.61% 45 Missing and 2 partials ⚠️
state/state.go 0.00% 15 Missing ⚠️
tx/transaction.go 0.00% 14 Missing and 1 partial ⚠️
txpool/validation.go 7.14% 12 Missing and 1 partial ⚠️
consensus/validator.go 0.00% 11 Missing and 1 partial ⚠️
packer/flow.go 0.00% 7 Missing and 1 partial ⚠️
txpool/tx_object.go 0.00% 7 Missing and 1 partial ⚠️
tx/builder.go 0.00% 7 Missing ⚠️
consensus/consensus.go 40.00% 2 Missing and 1 partial ⚠️
tx/features.go 90.90% 1 Missing ⚠️
Additional details and impacted files
@@                  Coverage Diff                  @@
##           release/galactica    #1008      +/-   ##
=====================================================
- Coverage              62.16%   61.84%   -0.33%     
=====================================================
  Files                    226      226              
  Lines                  23700    23844     +144     
=====================================================
+ Hits                   14733    14746      +13     
- Misses                  7825     7947     +122     
- Partials                1142     1151       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants