Move LinkedList to it's own service#1217
Merged
otherview merged 45 commits intoAug 4, 2025
Merged
Conversation
…thor into pedro/hayabusa/refact_housekeep
…/thor into pedro/hayabusa/refact_Transition
…/thor into pedro/hayabusa/refact_Transition
…abusa/refact_Transition
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## release/hayabusa #1217 +/- ##
=================================================
Coverage 58.24% 58.25%
=================================================
Files 273 274 +1
Lines 28966 28963 -3
=================================================
+ Hits 16870 16871 +1
- Misses 10629 10653 +24
+ Partials 1467 1439 -28 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…abusa/refact_Transition
…abusa/staker_cleanup_linked_list
…taker_cleanup_linked_list
otherview
marked this pull request as ready for review
July 31, 2025 15:31
…' into pedro/hayabusa/staker_cleanup_linked_list
…m:vechain/thor into pedro/hayabusa/staker_cleanup_linked_list
libotony
reviewed
Aug 1, 2025
otherview
force-pushed
the
pedro/hayabusa/staker_cleanup_linked_list
branch
from
August 1, 2025 09:30
a70c76d to
20da6cd
Compare
otherview
force-pushed
the
pedro/hayabusa/staker_cleanup_linked_list
branch
from
August 1, 2025 09:41
8c62d28 to
e9d8d71
Compare
…abusa/refact_Transition
…' into pedro/hayabusa/staker_cleanup_linked_list
paologalligit
previously approved these changes
Aug 1, 2025
paologalligit
left a comment
Member
There was a problem hiding this comment.
Looks good to me, left a minor comment
Base automatically changed from
pedro/hayabusa/refact_Transition
to
release/hayabusa
August 4, 2025 15:21
…abusa/staker_cleanup_linked_list
paologalligit
approved these changes
Aug 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR refactors the staker linked list implementation to separate linked list operations from validation storage, improving performance and maintainability by eliminating redundant storage writes.
Key Changes
New
linked_listpackage: Created dedicated package atbuiltin/staker/linked_list/for linked list operationsSeparated storage concerns: Linked list now manages its own Next/Prev pointer storage independently from validation data
Clean separation:
Validationstruct no longer containsNext/PrevpointersEliminated redundant writes: Removed the 3-write problem where linked list operations required updating multiple
ValidationrecordsFocused storage operations: Linked list operations now only touch pointer storage, not validation data
Maintained API compatibility: External interfaces remain unchanged
Fixes # (issue)
Checklist: