improve linkedlist.Remove#1218
Closed
libotony wants to merge 1 commit into
Closed
Conversation
darrenkel
reviewed
Aug 1, 2025
| next := validation.Next | ||
|
|
||
| // verify the entry exists in the linked list | ||
| validatorEntry, err := l.repo.GetValidation(validator) |
Contributor
There was a problem hiding this comment.
Not sure if this code covers it, but there is a scenario where a Validation with nil prev and next values gets passed into eg, leadergroup or queued. This would essentially delete the whole linked list since we set head and tail values to nil
Member
Author
There was a problem hiding this comment.
Removed code is just to ensure the validation exists. Your question is covered in Line 76
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Validation is passed in, no need to verify.
Checklist: