Skip to content

Darren/fix/solo blocks with same timestamps#1219

Merged
darrenkel merged 6 commits into
release/hayabusafrom
darren/fix/solo-blocks-with-same-timestamps
Aug 1, 2025
Merged

Darren/fix/solo blocks with same timestamps#1219
darrenkel merged 6 commits into
release/hayabusafrom
darren/fix/solo-blocks-with-same-timestamps

Conversation

@darrenkel

Copy link
Copy Markdown
Contributor

Description

fix for solo: prevent blocks using the same timestamp. This changes essentially creates blocks with future timestamps if solo is creating a lot of blocks

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • New and existing E2E tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have not added any vulnerable dependencies to my code

@darrenkel
darrenkel requested a review from a team as a code owner August 1, 2025 11:25
@darrenkel
darrenkel changed the base branch from master to release/hayabusa August 1, 2025 11:25
Comment thread cmd/thor/solo/core.go Outdated
@codecov-commenter

codecov-commenter commented Aug 1, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 58.24%. Comparing base (ba7f0a6) to head (82da053).
⚠️ Report is 1 commits behind head on release/hayabusa.

Additional details and impacted files
@@                 Coverage Diff                  @@
##           release/hayabusa    #1219      +/-   ##
====================================================
- Coverage             58.26%   58.24%   -0.03%     
====================================================
  Files                   273      273              
  Lines                 28875    28966      +91     
====================================================
+ Hits                  16824    16871      +47     
- Misses                10610    10628      +18     
- Partials               1441     1467      +26     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Co-authored-by: libotony <tony.li@vechain.org>
@darrenkel
darrenkel merged commit a11c287 into release/hayabusa Aug 1, 2025
25 checks passed
@darrenkel
darrenkel deleted the darren/fix/solo-blocks-with-same-timestamps branch August 1, 2025 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants