Feat/reward metadata #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #37 +/- ##
==========================================
+ Coverage 93.91% 93.95% +0.03%
==========================================
Files 55 55
Lines 3532 3538 +6
Branches 783 783
==========================================
+ Hits 3317 3324 +7
+ Misses 215 214 -1 ☔ View full report in Codecov by Sentry. |
Agilulfo1820
approved these changes
Feb 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrade
X2EarnRewardsPoolto Version 6This upgrade introduces the ability for XApps to include metadata in the reward distribution process, enabling richer and more context-specific information to be stored and emitted during events. A new function,
distributeRewardWithProofAndMetadata, has been added for this purpose.Key Updates
distributeRewardWithProoffunction remains unchanged and continues to work as before for apps that do not wish to use metadata.distributeRewardWithProofAndMetadatafunction accepts a string intended to be a JSON representation. A dedicated event,RewardMetadata, is emitted to store this information, following the established internal standards of_emitProof.Changes 🚀
X2EarnRewardsPool.solupdated to version6.Storage Changes 📦
New Features 🚀
X2EarnRewardsPool:distributeRewardWithProofAndMetadata(), which accepts a string intended to be a JSON representation and emits a new event,RewardMetadata, containing this information._emitMetadata, following the_emitProofpattern, to emit the event with the JSON data.Bug Fixes 🐛