docs(x2earn-rewards-pool): V9 - separate sustainable from bonus rewards#36
Draft
Agilulfo1820 wants to merge 1 commit into
Draft
docs(x2earn-rewards-pool): V9 - separate sustainable from bonus rewards#36Agilulfo1820 wants to merge 1 commit into
Agilulfo1820 wants to merge 1 commit into
Conversation
vechain/vebetterdao#3398 - Document distributeNonProofReward (V9) and the NonProofRewardCategory enum (Endorser / Leaderboard / Streak / Cashback / Referral / Other). This entrypoint does NOT register a passport action and emits the dedicated NonProofRewardDistributed event so indexers can exclude these payouts from personhood signals. - Mark the proof arrays as mandatory on every distributeRewardWithProof* entrypoint (V9): empty arrays revert with 'X2EarnRewardsPool: proof is mandatory'. The pre-V9 'at least proof OR impact' relaxation no longer applies. - Mark distributeReward as DEPRECATED in V9 (kept for backward compatibility) and add distributeRewardDeprecatedForRound to the distribution-function tables. - Refresh the x-2-earn-apps Solidity example to call distributeRewardWithProof with typed arrays and add a distributeNonProofReward leaderboard-prize example. - Refresh the vebetterdao backend / multi-clause examples to use the V9-compliant entrypoints.
Skill Security AuditScanned 75 file(s) — found 14 issue(s) across 5 file(s). 🔵 LOW (14)
|
Skill Size Report
Large reference files (>5.0K tok)
|
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tracks the X2EarnRewardsPool V9 contract change in vechain/vebetterdao#3398.
Changes
NonProofRewardCategoryenum table, V9-aware distribution-functions matrix, and bonus-reward JS + Solidity examples. Updated the mandatory-proof rule to reflect V9.distributeRewardWithProof(typed arrays, V9-compliant) and added apayLeaderboardPrizeexample usingdistributeNonProofReward.NonProofRewardCategoryanddistributeNonProofReward; Solidity / JS / multi-clause examples switched to the V9 entrypoints; mandatory-rule note updated.distributeReward, and an overview of the sustainable / bonus / legacy flows.Test plan
NonProofRewardCategoryenum order against the V9 interface