Migrate from NPM tokens to trusted publisher workflow. Fix tests. #313
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cjcenizal
force-pushed
the
chore/publish-trusted-workflow
branch
from
0e64ae5 to
42c7efa
Compare
musabsohail
approved these changes
Dec 3, 2025
|
|
||
| - uses: actions/setup-node@v4 | ||
| with: | ||
| node-version: "20" |
Contributor
There was a problem hiding this comment.
.nvmrc has version v18.13.0
| needs: [check-version-change] | ||
| if: needs.check-version-change.outputs.did-version-change == 'true' | ||
| steps: | ||
| - uses: actions/checkout@v4 |
Contributor
There was a problem hiding this comment.
Also you might want to check actions/checkout@v4 here and v2 on line 46.
Contributor
Author
There was a problem hiding this comment.
Good catch! Thanks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NPM is sunsetting the old tokens that we were using to publish to NPM. They advise using trusted publishers for publishing via CI/CD instead.
This change will also run the unit tests before publishing. Apparently we haven't ran them in a while, so they needed fixing. As part of the fix, I noticed VuiSummary produced invalid DOM (nesting divs inside of a p tag), so I fixed that too.