Skip to content

Conversation

@nzxwang
Copy link
Contributor

@nzxwang nzxwang commented Apr 22, 2025

Summary

This PR resolves #21881 by enhancing the enrichment functions with support for single-bounded date range search. It's implementation is the addition of FromDate and ToDate to the enum Condition and their respective handling.

Sidenote: I've been using vector for 1.5 years now but have never contributed nor written anything in rust before. I would like to become more knowledgeable of the codebase and a more active contributor so I welcome all feedback. Thank you in advance.

Change Type

  • Bug fix
  • New feature
  • Non-functional (chore, refactoring, docs)
  • Performance

Is this a breaking change?

  • Yes
  • No

How did you test this PR?

I ran unit tests:

cargo vdev test finds_row finds_rows_with_index_case_sensitive finds_rows_with_index_case_insensitive finds_row_between_dates finds_row_from_date finds_row_to_date
###
Summary [   5.404s] 8 tests run: 8 passed, 2374 skipped

Does this PR include user facing changes?

  • Yes. Please add a changelog fragment based on our guidelines.
  • No. A maintainer will apply the "no-changelog" label to this PR.

@bits-bot
Copy link

bits-bot commented Apr 22, 2025

CLA assistant check
All committers have signed the CLA.

@nzxwang nzxwang changed the title Single bounded date enhancement(enriching): add from and to date search to enrichment tables Apr 22, 2025
@nzxwang nzxwang force-pushed the single-bounded-date branch from f9d02b8 to cfeb009 Compare April 23, 2025 00:08
@github-actions github-actions bot added the domain: external docs Anything related to Vector's external, public documentation label Apr 23, 2025
@nzxwang nzxwang force-pushed the single-bounded-date branch from cfeb009 to 2af062d Compare May 5, 2025 18:29
@nzxwang nzxwang marked this pull request as ready for review May 5, 2025 18:30
@nzxwang nzxwang requested review from a team as code owners May 5, 2025 18:30
@maycmlee maycmlee self-assigned this May 5, 2025
@maycmlee maycmlee removed their assignment May 5, 2025
Copy link
Member

@pront pront left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @nzxwang

@nzxwang
Copy link
Contributor Author

nzxwang commented May 7, 2025

Thank you @pront and DeForest for your approvals.

The PR template states that the CI checks run only after a manual approval. Is there further action required on my part to unblock that or merging of this PR?

@pront
Copy link
Member

pront commented May 9, 2025

Thank you @pront and DeForest for your approvals.

The PR template states that the CI checks run only after a manual approval. Is there further action required on my part to unblock that or merging of this PR?

I am taking another look now and if there is nothing else to do I will enqueue for merging.

@pront pront enabled auto-merge May 15, 2025 17:06
@pront pront added this pull request to the merge queue May 15, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 15, 2025
@pront pront added this pull request to the merge queue May 16, 2025
Merged via the queue into vectordotdev:master with commit 1d232fb May 16, 2025
42 checks passed
@nzxwang nzxwang deleted the single-bounded-date branch May 19, 2025 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

domain: external docs Anything related to Vector's external, public documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Enrichment functions Singly-bounded Date range search

6 participants