-
Notifications
You must be signed in to change notification settings - Fork 2k
enhancement(enriching): add from and to date search to enrichment tables #22926
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
f9d02b8 to
cfeb009
Compare
cfeb009 to
2af062d
Compare
pront
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @nzxwang
changelog.d/22926_enrichment_function_single_bounded_date_range_search.enhancement.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Pavlos Rontidis <[email protected]>
Co-authored-by: Pavlos Rontidis <[email protected]>
…e_search.enhancement.md Co-authored-by: Pavlos Rontidis <[email protected]>
|
Thank you @pront and DeForest for your approvals. The PR template states that the CI checks run only after a manual approval. Is there further action required on my part to unblock that or merging of this PR? |
I am taking another look now and if there is nothing else to do I will enqueue for merging. |
Summary
This PR resolves #21881 by enhancing the enrichment functions with support for single-bounded date range search. It's implementation is the addition of
FromDateandToDateto theenum Conditionand their respective handling.Sidenote: I've been using vector for 1.5 years now but have never contributed nor written anything in rust before. I would like to become more knowledgeable of the codebase and a more active contributor so I welcome all feedback. Thank you in advance.
Change Type
Is this a breaking change?
How did you test this PR?
I ran unit tests:
Does this PR include user facing changes?