fix(config): watch-config file events handling #23899
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Config watcher no longer ignores subsequent events during the delay period, but collects the changed paths and reloads the corresponding components.
Vector configuration
./config/sources.yaml
./config/transforms.yaml
./config/sinks.yaml
./config/test.vrl
How did you test this PR?
vector -vv -C ./config -w
config
foldercp -R config config-copy
test.vrl
to.debug = "external_01_modified"
insideconfig-copy
source
oftest-embedded-vrl
to.debug = "embedded_01_modified"
insideconfig-copy
rm -rf config && cp -R config-copy config
Change Type
Is this a breaking change?
Does this PR include user facing changes?
no-changelog
label to this PR.References
Notes
@vectordotdev/vector
to reach out to us regarding this PR.pre-push
hook, please see this template.make fmt
make check-clippy
(if there are failures it's possible some of them can be fixed withmake clippy-fix
)make test
git merge origin master
andgit push
.Cargo.lock
), pleaserun
make build-licenses
to regenerate the license inventory and commit the changes (if any). More details here.