Skip to content

Conversation

pront
Copy link
Member

@pront pront commented Oct 8, 2025

Summary

The component features check is one of our most resource-intensive CI jobs:

  • Runs 200+ individual feature builds (one for each component feature in isolation)
  • Takes 1+ hours to complete
  • Typically fails only after a new component was introduced (can run it on demand before merging those)
  • Running 5x per week on schedule is excessive for a check that validates feature gate correctness

Pros:

  • Significant cost savings - 80% reduction in scheduled runs (5/week → 1/week)
  • Still catches issues - weekly run ensures feature gate bugs don't accumulate
  • On-demand available - can still trigger manually or via PR review when needed

Cons:

  • Longer feedback loop - feature gate bugs might not be caught until the following Monday
  • One run can expose more than one issue, slightly harder to fix. Although this is possible today e.g. we merge two PRs and both introduce a new issue.
  • Monday disruption - failures will require attention early in the week

Future work:

Vector configuration

How did you test this PR?

Change Type

  • Bug fix
  • New feature
  • Non-functional (chore, refactoring, docs)
  • Performance

Is this a breaking change?

  • Yes
  • No

Does this PR include user facing changes?

  • Yes. Please add a changelog fragment based on our guidelines.
  • No. A maintainer will apply the no-changelog label to this PR.

References

Notes

  • Please read our Vector contributor resources.
  • Do not hesitate to use @vectordotdev/vector to reach out to us regarding this PR.
  • Some CI checks run only after we manually approve them.
    • We recommend adding a pre-push hook, please see this template.
    • Alternatively, we recommend running the following locally before pushing to the remote branch:
      • make fmt
      • make check-clippy (if there are failures it's possible some of them can be fixed with make clippy-fix)
      • make test
  • After a review is requested, please avoid force pushes to help us review incrementally.
    • Feel free to push as many commits as you want. They will be squashed into one before merging.
    • For example, you can run git merge origin master and git push.
  • If this PR introduces changes Vector dependencies (modifies Cargo.lock), please
    run make build-licenses to regenerate the license inventory and commit the changes (if any). More details here.

@pront pront requested a review from a team as a code owner October 8, 2025 12:57
@pront pront added the no-changelog Changes in this PR do not need user-facing explanations in the release changelog label Oct 8, 2025
@pront pront enabled auto-merge October 8, 2025 13:07
@pront pront added this pull request to the merge queue Oct 8, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Oct 8, 2025
@pront pront merged commit cdb9e3c into master Oct 8, 2025
58 checks passed
@pront pront deleted the pront-change-schedule branch October 8, 2025 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-changelog Changes in this PR do not need user-facing explanations in the release changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants