fix(instrument): Buffer counter underflowed (#23872) #23973
+32
−20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @sialais, thank you for the PR! Please add a changelog explaining the change. |
sialais
force-pushed
the
bugfix/fix_buffer_counter_underflowed
branch
from
fcc55dd to
b222f23
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix issue #23872
How did you test this PR?
Because the issue is hard to reproduce, (I can only reproduce it in my production environment, with huge data), I put my build on my production environment, and the issue fixed.
This bug will make the self monitoring metrics incorrect: when buffer counter undeflowed, metrics will be reset.
Change Type
Is this a breaking change?
Does this PR include user facing changes?
no-changeloglabel to this PR.References