[clippy allow cleanup] Clean up clippy allows for vdev #23991
+23
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Disabling module_name_repetitions did not yield any clippy errors. Reference: https://rust-lang.github.io/rust-clippy/master/index.html#module_name_repetitions
Move the clippy::print_stdout allow directive from global scope to the commands module where stdout printing is actually needed. This ensures print statements are only used where appropriate for CLI output.
Relocates the clippy::unused_self allow from main.rs to the commands module where it's actually needed.
Moves the clippy::unnecessary_wraps allow from the crate level to the commands module where it's actually needed. Command exec() methods return Result<()> for consistency even when they cannot fail, enabling uniform error handling across the command interface.
Run `make generate-component-docs` to update documentation for components.
github-actions
bot
added
domain: external docs
divoxx
commented
Oct 11, 2025
Comment on lines
+5
to
+11
| // The cli_commands! macro generates exec() methods for all commands. Some commands | ||
| // use self while others don't, so we allow unused_self to avoid false warnings. | ||
| clippy::unused_self, | ||
| // All command exec() methods return Result<()> for consistency, even when they | ||
| // cannot fail. This allows uniform error handling across the command interface. | ||
| clippy::unnecessary_wraps, |
There was a problem hiding this comment.
Currently, the macro cli_commands require these, as some of the implementations does require accessing self or returning an error. Because of that, I simply moved these so that it applies only for the commands module.
pront
approved these changes
Oct 13, 2025
| required: false | ||
| type: object: { | ||
| examples: [{}] | ||
| examples: [{}, |
There was a problem hiding this comment.
Can you run make generate-component-docs again?
pront
added
the
no-changelog
urseberry
approved these changes
Oct 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
First PR tackling the investigation and clean up of clippy allows in the repository.
As a first pass, this removes the allows that are possible to remove and narrows the scopes of the ones which are currently required.
Vector configuration
How did you test this PR?
cargo clippyandcargo test, and the suggestedpre-pushhookChange Type
Is this a breaking change?
Does this PR include user facing changes?
no-changeloglabel to this PR.References
Related: #23659
Notes
@vectordotdev/vectorto reach out to us regarding this PR.pre-pushhook, please see this template.make fmtmake check-clippy(if there are failures it's possible some of them can be fixed withmake clippy-fix)make testgit merge origin masterandgit push.Cargo.lock), pleaserun
make build-licensesto regenerate the license inventory and commit the changes (if any). More details here.