-
Notifications
You must be signed in to change notification settings - Fork 94
feat(stdlib): add http_request
function
#1360
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Regarding the Cargo.lock
, the is a large number of line changes; can you revert and re-apply the cargo update only for the affected dependencies?
@pront I ran the following:
but unfortunately the lock-file changes are pretty big. I suppose it must be that reqwest a lot of dependencies, even with some default features disabled I think it would be good to keep the other default features if possible, e.g. support for HTTP/2 |
Oh yes, WASM builds fail: https://github.com/vectordotdev/vrl/actions/runs/15653270457/job/44203895862?pr=1360 It's possible to support it but you can also disable this function from WASM builds. |
Head branch was pushed to by a user without write access
Hey @pront, I've disabled it from the WASM build for now |
Head branch was pushed to by a user without write access
Head branch was pushed to by a user without write access
786639c
to
eb99c99
Compare
Ah, there's a license not recognized by |
# MPL-2.0 are added case-by-case to make sure we are in compliance. To be in | ||
# compliance we cannot be modifying the source files. | ||
{ allow = ["MPL-2.0"], name = "vrl", version = "*" }, | ||
{ allow = ["CDLA-Permissive-2.0"], name = "webpki-roots", version = "*" }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to think a bit about this one. No actions needed from you @benjamin-awd. Thank you for your patience!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Understood, thanks @pront!
Summary
This PR adds a HTTP request function, allowing users to fetch data from external sources.
Change Type
Is this a breaking change?
How did you test this PR?
Added tests, otherwise currently running this in a Kubernetes environment via Helm.
Does this PR include user facing changes?
our guidelines.
dns_lookup
)Checklist
run
dd-rust-license-tool write
and commit the changes. More details here.References
Closes #1359