feat(stdlib): add http_request function
#1360
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benjamin-awd
commented
Mar 27, 2025
Comment on lines
+688
to
+699
| bench_function! { | ||
| http_request => vrl::stdlib::HttpRequest; | ||
|
|
||
| http_request { | ||
| args: func_args![ | ||
| url: value!("https://httpbin.org/bearer"), | ||
| headers: value!({"accept": "application/json", "Authorization": "Bearer my_token"}) | ||
| ], | ||
| want: Ok(r#"{"authenticated": true, "token": "my_token"}"#), | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
I'm not sure about this benchmark since making network calls like this isn't very reliable, running this specific benchmark gives back:
Benchmarking vrl_stdlib/functions/http_request/http_request: Warming up for 3.0000 s
Warning: Unable to complete 100 samples in 5.0s. You may wish to increase target time to 154.0s, or reduce sample count to 10.
Benchmarking vrl_stdlib/functions/http_request/http_request: Collecting 100 samples in estimated 154.03 s (100 iterations)
vrl_stdlib/functions/http_request/http_request
time: [1.4146 s 1.5196 s 1.6320 s]
thrpt: [0.6128 elem/s 0.6581 elem/s 0.7069 elem/s]
Found 9 outliers among 100 measurements (9.00%)
8 (8.00%) high mild
1 (1.00%) high severe
Maybe something with warp would be more useful
benjamin-awd
commented
Mar 27, 2025
Comment on lines
+166
to
+168
| // Create a new Tokio runtime as a fallback | ||
| let runtime = Runtime::new().expect("Failed to create Tokio runtime"); | ||
| runtime.block_on(async { http_request(&url, &method, headers).await }) |
There was a problem hiding this comment.
This was added to allow the bench function to run -- AFAICT it isn't needed apart from that since the Vector runtime can be accessed with Handle::current()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds a HTTP request function, allowing users to fetch data from external sources.
Change Type
Is this a breaking change?
How did you test this PR?
Added tests, otherwise currently running this in a Kubernetes environment via Helm.
Does this PR include user facing changes?
our guidelines.
dns_lookup)Checklist
run
dd-rust-license-tool writeand commit the changes. More details here.References
Closes #1359