Skip to content

enhancement(lz4_decode) add lz4_decode compression type detection #1367

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

jimmystewpot
Copy link
Contributor

@jimmystewpot jimmystewpot commented Apr 2, 2025

Summary

In a previous PR #1339, LZ4 block compression was added. That change focused on adding LZ4 block compression and decompression support. With Lz4, there are two types of compression: frame and block. This change supports detecting if the value being decoded is compressed using LZ4 frame compression and attempts to handle it gracefully.

Change Type

  • Bug fix
  • New feature
  • Non-functional (chore, refactoring, docs)
  • Performance

Is this a breaking change?

  • Yes
  • No

How did you test this PR?

I have run through the various scripts in scripts and added an additional test to decompress an LZ4 frame payload.

Does this PR include user-facing changes?

  • Yes. Please add a changelog fragment based on
    our guidelines.
  • [] No. A maintainer will apply the "no-changelog" label to this PR.

Checklist

  • Our CONTRIBUTING.md is a good starting place.
  • If this PR introduces changes to LICENSE-3rdparty.csv, please
    run dd-rust-license-tool write and commit the changes. More details here.
  • For new VRL functions, please also create a sibling PR in Vector to document the new function.

@jimmystewpot jimmystewpot changed the title enhancement(lz4_decode) add lz4 compression type detection enhancement(lz4_decode) add lz4_decode compression type detection Apr 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants