Upstream child frame preview - #338

Open

aikrahguzar wants to merge 95 commits into

vedang:masterfrom

aikrahguzar:upstream-child-frame-preview

Commits on Feb 5, 2026

Implement a child frame based preview for links

aikrahguzar
authored and
Rahguzar
committed
a02d45b
Reinterpret pdf-isearch-narrow-to-page for pdf-roll

aikrahguzar
authored and
Rahguzar
committed
ab5f673
Add an isearch version of preview command

aikrahguzar
authored and
Rahguzar
committed
eaf2124
Actually set the variable in `pdf-roll-margin-color` :set

aikrahguzar
authored and
Rahguzar
committed
dc6eebd
Make sure not to pass nil to make-frame-invisible

aikrahguzar
authored and
Rahguzar
committed
fa725e1
Make backward sync accurate with long source lines

aikrahguzar
authored and
Rahguzar
committed
ef14959
Prioritize alignment of larger words

aikrahguzar
authored and
Rahguzar
committed
99f756d
A hueristic for forward search

aikrahguzar
authored and
Rahguzar
committed
ea9dead
Don't search non-existent pages

aikrahguzar
authored and
Rahguzar
committed
91cd035
Only use heuristic if regexp has a single match

aikrahguzar
authored and
Rahguzar
committed
751ebe0
Make sure the child frame exists

aikrahguzar
authored and
Rahguzar
committed
61c3ceb
Add ability to auto trigger child frame preview

aikrahguzar
authored and
Rahguzar
committed
7565abb
Allow cursor on margin

aikrahguzar
authored and
Rahguzar
committed
28e8249
Fix pdf-sync when slicing is involved

aikrahguzar
authored and
Rahguzar
committed
59859ab
Make auto-slicing work properly with pdf-roll

aikrahguzar
authored and
Rahguzar
committed
572abba
Fix preview due to erratic 'pos-visible-in-window-p'

aikrahguzar
authored and
Rahguzar
committed
55efc70
auto-slicing: also set/reset default slice

aikrahguzar
authored and
Rahguzar
committed
8ea4e73
Fix docstring for p-r-maybe-slice-images

aikrahguzar
authored and
Rahguzar
committed
d580c7c
Use save-restriction with small body.

aikrahguzar
authored and
Rahguzar
committed
0018057
Fix mouse scrolling of child frame

aikrahguzar
authored and
Rahguzar
committed
c81dd60
Fix help-echo calling convention + preview from non-selected win

aikrahguzar
authored and
Rahguzar
committed
0e04694
Fix calculation of child-frame coordinates

aikrahguzar
authored and
Rahguzar
committed
3c1f5ff
Reset state when child frame is hidden

aikrahguzar
authored and
Rahguzar
committed
fc94189
When preview is visible scroll the preview

aikrahguzar
authored and
Rahguzar
committed
888d6d6
Fix moving over a new link while preview is active

aikrahguzar
authored and
Rahguzar
committed
55f3a6f
Hopefully prevent erratic point movement

aikrahguzar
authored and
Rahguzar
committed
db6b602
Add setter for pdf-links-child-frame-parameters

aikrahguzar
authored and
Rahguzar
committed
01dec87
Remove fringes

aikrahguzar
authored and
Rahguzar
committed
69a1bd0
Allow overriding vscroll setting from the link

aikrahguzar
authored and
Rahguzar
committed
e4c0f4d
Fringes redux + little reorganization

aikrahguzar
authored and
Rahguzar
committed
7697b30
Mark preview buffer as unimportant

aikrahguzar
authored and
Rahguzar
committed
ca6ad05
Tiny simplification

aikrahguzar
authored and
Rahguzar
committed
58a0706
Adapting to changes in pdf-view-goto-page

aikrahguzar
authored and
Rahguzar
committed
297d8c5
Further adjustments

aikrahguzar
authored and
Rahguzar
committed
2fbd580
Take 3

aikrahguzar
authored and
Rahguzar
committed
a1cd244
Better scrolling for single page pdf

aikrahguzar
authored and
Rahguzar
committed
b4f8bc1
Handle function value for slice when jumping to a bookmark

aikrahguzar
authored and
Rahguzar
committed
4ed4aad
Another tweak to scrolling on the last page

aikrahguzar
authored and
Rahguzar
committed
be2aa79
Refactor bookmark handling

aikrahguzar
authored and
Rahguzar
committed
ffd52ad
Don't make the last entry of bookmark record a constant

aikrahguzar
authored and
Rahguzar
committed
e8abe6e
More accurate forward search using synctex subprocess

aikrahguzar
authored and
Rahguzar
committed
c420f02
Restore origin only once

aikrahguzar
authored and
Rahguzar
committed
9d189ab
Avoid pos-visible-in-window-p during redisplay

aikrahguzar
authored and
Rahguzar
committed
9079e30

Commits on Feb 6, 2026

Correct clamping of bounding box

aikrahguzar
authored and
Rahguzar
committed
25961dd
Include window point in state, not the point

aikrahguzar
authored and
Rahguzar
committed
fdb42c0
Simplify scroll-forward/backward

aikrahguzar
authored and
Rahguzar
committed
3b37237
Command to scroll to the end of last displayed page

aikrahguzar
authored and
Rahguzar
committed
7956562
Handle negative arg to scroll forward/backward correctly

aikrahguzar
authored and
Rahguzar
committed
3c72d3d
Command to go to position of a mouse event

aikrahguzar
authored and
Rahguzar
committed
59cf449
Don't activate mark as it can mess up internal-region-overlay

aikrahguzar
authored and
Rahguzar
committed
4bebdf2
Take slicing into account when computing required vscroll

aikrahguzar
authored and
Rahguzar
committed
e194485
Fix child frame preview with slices.

aikrahguzar
authored and
Rahguzar
committed
8b9b423
Don't assume we are only ones creating overlays in the buffer

aikrahguzar
authored and
Rahguzar
committed
ea1a2f2
Revert "Don't activate mark as it can mess up ..."

aikrahguzar
authored and
Rahguzar
committed
d14907a
Fix subtracting offset twice from tooltip location + formatting

aikrahguzar
authored and
Rahguzar
committed
edcf4da
Remove a re-search-forward

aikrahguzar
authored and
Rahguzar
committed
7cd704a
Allowing the choice between highlighting and tooltip in sync
Rahguzar
committed
9fb3968
Unhighlight pages even when the window disappear
Rahguzar
committed
93c1111
Prevent errors if prefetching starts too early for us
Rahguzar
committed
d075653
Fix error in pdf-links if pdf-roll is not loaded.
Rahguzar
committed
0e315e2
Reset state on revert
Rahguzar
committed
1f4c04b
Use defvars to accomplish what pdf-roll needs
Rahguzar
committed
f9675d8
Fix pdf-view-image-offset to return integers
Rahguzar
committed
07c0b49
Slight refactor of pdf-roll-scroll-to-end-of-page
Rahguzar
committed
58956d2
Limit pixel scrolling exception to pre-redisplay
Rahguzar
committed
03bd69d
Make sure to find the correct overlay
Rahguzar
committed
45b9cc0
Put back part of the hack for pixel-scroll-precision-mode
Rahguzar
committed
df14c2b
Don't create image when caching image data
Rahguzar
committed
4452e4b
Aggressively flush images
Rahguzar
committed
0ee3bbc
Flush previous images without pdf-roll too
Rahguzar
committed
eee10f1
Silence some byte compiler warnings
Rahguzar
committed
a39251f
Don't try to flush when there is no image
Rahguzar
committed
8b5350c
Fix tooltip arrow to work with new defvars
Rahguzar
committed
59b6398
Use enable-theme-functions on Emacs > 28
Rahguzar
committed
52246f4
Fix bookmark-make-record to work without displayed images
Rahguzar
committed
f6bff39
redisplay: add ultra-scroll functions to pscrolling lexical

marty hiatt
authored and
Rahguzar
committed
044c96a
roll: fix remap of scroll up/down (SPC binding).

marty hiatt
authored and
Rahguzar
committed
99f0c26
pdf-links-preview: explicitly set image-scaling-factor to 1
Rahguzar
committed
564ffb2
Don't try to find origin of buffers not displayed in a live window
Rahguzar
committed
909267e
Fix #10: Remap isearch face so that the prefix is not highlighted
Rahguzar
committed
0566a7d
Fix region dragging
Rahguzar
committed
a8f1d61
Fix #11
Rahguzar
committed
d791426
Stop Emacs 30 from computing original map in create-image
Rahguzar
committed
aee49c9
Don't use image-size during redisplay
Rahguzar
committed
b6ca1d9
Value t for :original-map is dangerous
Rahguzar
committed
161e827
Fix vedang/pdf-tools#341
Rahguzar
committed
d43120d
Fix vedang/pdf-tools#340
Rahguzar
committed
96f3967
Consider all windows when turning off pdf-view-roll-minor-mode
Rahguzar
committed
be1a29e
Loop over winprops directly when turning off pdf-roll
Rahguzar
committed
8ba82ee
Don't use 'displayed-pages winprop outside pdf-roll
Rahguzar
committed
26dde29

Commits on Feb 15, 2026

Revert changes related to flushing images to conserve memory.
Rahguzar
committed
cd85c52

Commits on Mar 6, 2026

Avoid hitting the assertion pdf-view-new-window-function
Rahguzar
committed
3b35438
Fix typo in quoting and a little reformatting
Rahguzar
committed
b80b49c

Commits on Jun 6, 2026

Ensure only one overlay per window: fix #349
Rahguzar
committed
facefc2

Commits on Jul 3, 2026

Fix region dragging
Rahguzar
committed
8103caf