feat: support sidekiq 8 #90
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wrapper class names for Active Job support have changed in Sidekiq 8. https://github.com/sidekiq/sidekiq/blob/main/Changes.md#800 > WARNING The underlying class name for Active Jobs has changed from ActiveJob::QueueAdapters::SidekiqAdapter::JobWrapper to Sidekiq::ActiveJob::Wrapper. The old name will still work in 8.x. Adding Sidekiq::ActiveJob::Wrapper to the class check in the sidekiq patch.
irphilli
force-pushed
the
sidekiq-8-support
branch
from
bdb64eb to
b65a212
Compare
|
Thank you for creating the PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses #87
Wrapper class names for Active Job support have changed in Sidekiq 8. https://github.com/sidekiq/sidekiq/blob/main/Changes.md#800
Adding Sidekiq::ActiveJob::Wrapper to the class check in the sidekiq patch.