Add support for ActiveJob 7.1#39
Closed
shashankmehra wants to merge 17 commits intoveeqo:mainfrom
Closed
Conversation
Fix the CI pipeline and drop support for older Rails versions
Clean up CI build matrix
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Breaking changes addressed
Action Mailer exception
In ActionMailer 7.1+ the following call throws an exception:
This is because
MailDeliveryJobaccepts theMaileras the first argument and uses the mailer dynamically to get the queue name usingdeliver_later_queue_name. So, callingqueue_namewithout passing the arguments throws an exception.The only way to pass arguments is to call
perform_later- which we cannot do just to get queue_name.This was solved by adding special handling for
MailDeliveryJob. We usedeliver_later_queue_namefrom the mailer itself to get the queue name - same asMailDeliveryJob.Checklist