Skip to content

Add support for ActiveJob 7.1#39

Closed
shashankmehra wants to merge 17 commits intoveeqo:mainfrom
BranchIntl:add-support-for-action-mailers
Closed

Add support for ActiveJob 7.1#39
shashankmehra wants to merge 17 commits intoveeqo:mainfrom
BranchIntl:add-support-for-action-mailers

Conversation

@shashankmehra
Copy link
Copy Markdown
Contributor

Breaking changes addressed

Action Mailer exception

In ActionMailer 7.1+ the following call throws an exception:

ActionMailer::MailDeliveryJob.new.queue_name

This is because MailDeliveryJob accepts the Mailer as the first argument and uses the mailer dynamically to get the queue name using deliver_later_queue_name. So, calling queue_name without passing the arguments throws an exception.

The only way to pass arguments is to call perform_later - which we cannot do just to get queue_name.

This was solved by adding special handling for MailDeliveryJob. We use deliver_later_queue_name from the mailer itself to get the queue name - same as MailDeliveryJob.

Checklist

  • Make sure existing tests pass
  • Write tests for expanded functionality of Mailer specific queue
  • Update Changelog

@adis-io adis-io mentioned this pull request Apr 8, 2026
3 tasks
@adis-io
Copy link
Copy Markdown
Contributor

adis-io commented Apr 9, 2026

#42

@adis-io adis-io closed this Apr 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants