fix: DOS time parser handles space before AM/PM#144
Merged
Conversation
|
✔️ 533a46d - Conventional commits check succeeded. |
Some FTP servers format DOS timestamps with a space before AM/PM (e.g. '01:30 PM' vs '01:30PM'). The parser now tries both formats. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
veeso
force-pushed
the
fix/dostime-ampm-space
branch
from
533a46d to
ca2979a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
"%I:%M %p"(with space before AM/PM) to the DOS timestamp parser01:30 PMinstead of01:30PMSeverity
Medium — Directory listings from servers using the spaced format would fail to parse entirely.
Test plan
cargo testpasses01:30PMand01:30 PMformats parse correctly🤖 Generated with Claude Code