fix: active mode uses EPRT for IPv6 connections#145
Merged
Conversation
The PORT command only supports IPv4. When connected via IPv6, the client now uses EPRT instead. Also replaces unwrap() on local_addr() with proper error handling. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
✔️ d01e8d4...2a12a7e - Conventional commits check succeeded. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
local_addr().unwrap()with proper error handling returningFtpError::ConnectionErrorSeverity
Medium — Active mode transfers over IPv6 would always fail with a malformed PORT command. Additionally,
local_addr().unwrap()could panic.Test plan
cargo buildcompiles without errors across all feature combinations🤖 Generated with Claude Code