Fix FEL local execution data streaming and parameter handling #333
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Modified job.js submit() method to handle local execution when submit_type is "local" - Enhanced submit_local() function with proper error handling and status updates - Added LocalJobStatus class for local job monitoring - Added localJobDelete() function for local job cancellation - Updated CLIENT_INTEGRATION_GUIDE.md to document local execution option - Added test setup script for local execution verification This enables running bioinformatics analyses directly on the local machine without requiring TORQUE or SLURM schedulers. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
- Fix router.js to extract alignment data from first parameter as stream for FEL jobs - Add comprehensive logging to trace file writing process through server.js, fel.js, and hyphyjob.js - Fix tree data extraction by merging tree parameter into job params in server.js - Add branches parameter support to FEL job with proper shell script parsing - Change default resample value from 100 to 1 for faster execution - Fix hardcoded branch parameters (FG/All) to use dynamic BRANCHES variable in fel.sh Resolves issue where FEL jobs were writing empty alignment and tree files, now properly streams FASTA alignment data and Newick tree data to HYPHY. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
- Add comprehensive FEL analysis data format specification - Document new payload structure with alignment and tree data - Add complete event handling examples with data structures - Include working FELAnalysisClient class example - Add data validation requirements for FASTA and Newick formats - Update parameter validation and error handling sections - Distinguish FEL format from standard socket.io-stream format Provides complete integration guide for frontend developers to properly implement FEL analysis with the corrected data format. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Changes Made
Data Streaming Fixes
lib/router.js): Extract alignment data from first parameter as stream for FEL jobsserver.js): Merge tree data into job params and add comprehensive loggingapp/hyphyjob.js): Enhanced file writing with detailed logging and error handlingapp/fel/fel.js): Improved parameter extraction and tree data handlingParameter Handling
branchesparameter support with proper extraction and shell script parsing$BRANCHESvariableresamplevalue from 100 to 1 for faster executionLogging & Debugging
Files Modified
lib/router.js- Data extraction and routing fixesserver.js- Parameter merging and loggingapp/fel/fel.js- Parameter handling and constructor improvementsapp/fel/fel.sh- Dynamic parameter usage and branch selectionapp/hyphyjob.js- File writing enhancements and loggingTest Results
✅ Alignment files now contain proper FASTA data (585 bytes)
✅ Tree files now contain proper Newick data (214 bytes)
✅ HYPHY successfully processes both files
✅ FEL analysis completes successfully with real biological data
Technical Details
The issue was in the data flow pipeline:
{alignment: "...", tree: "...", job: {...}}stream = nullinstead of extracting alignment dataAll issues have been resolved and the complete pipeline now works end-to-end.
🤖 Generated with Claude Code