docs: Use relative instead of absolute paths for linked files#3627
Open
joelostblom wants to merge 1 commit intomainfrom
Open
docs: Use relative instead of absolute paths for linked files#3627joelostblom wants to merge 1 commit intomainfrom
joelostblom wants to merge 1 commit intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I tried running a website diff tool locally which crawls the paths to look for changes in linked files. I ran into issues with these absolute paths since the linked files don't exist in my local root directory. Changing them to relative seem to have no effect on the rendered altair docs, so I suggest we do so to unless anyone is aware of something this could break.