fix: preserve polars datetime timezones during serialization #3922
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 tasks
Contributor
|
Thanks for all the extra context in #3921, @kjgoodrick! Since it is connect to the narwhals integration within altair, would you be willing to review this PR @MarcoGorelli? |
MarcoGorelli
approved these changes
Dec 17, 2025
Contributor
MarcoGorelli
left a comment
MarcoGorelli
left a comment
There was a problem hiding this comment.
thanks for the ping! nice and simple fix 👍
Contributor
|
Thank you very much for this PR @kjgoodrick and review @MarcoGorelli! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3921 by preserving timezone information during sanitization when it is included in datetime columns. With this change there is no impact on naive datetimes.
Test added to keep track of DST boundary cases.