fix: Remove redundant settings for default theme#3983
Open
joelostblom wants to merge 9 commits intomainfrom
Open
fix: Remove redundant settings for default theme#3983joelostblom wants to merge 9 commits intomainfrom
joelostblom wants to merge 9 commits intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since vega/vega-lite#9566, there is no longer any difference between the default altair and the default Vega-Lite themes. This PR aims to clear up our theme config a bit and has the bonus of that we no longer will inject the custom view config line in every VL spec. We could consider deprecating some themes, but I also don't see any immediate need for that.