fix: correctly generate anyOf on unions with string and boolean constant #2208
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pixunil
commented
Mar 24, 2025
arthurfiorette
requested changes
Mar 24, 2025
| } | ||
| ] | ||
| }, | ||
| "var8": { |
There was a problem hiding this comment.
I'm unsure if we can use enum and type[] in the same type. Especially the combination of boolean, string, and true.
I'd bet that even if allowed, this would break in a lot of community parsers. Could we make this be a anyOf boolean const true and string enum s?
There was a problem hiding this comment.
isn’t this the analog case for var4 and var6, apart from using a number instead of boolean?
regarding whether it is allowed, at least for type and enum I don’t see a indication that they are exclusive (https://json-schema.org/draft/2020-12/draft-bhutton-json-schema-validation-01#section-6.1.1). it feels a bit redundant to specify both, as enum implicitly specifies type
pixunil
force-pushed
the
fix-union-string-with-constant-boolean
branch
from
b6dcdaa to
56bdaf7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as far as I understood while debugging through the test code,StringTypeis used forstringwhileLiteralTypeis used for a string constant like"s", thusStringTypecannot be part of a literal union.noticed that there is some magic regarding
stringwhich is hard to incorporate outside ofLiterallUnionTypeFormatter. but it appears to me that aStringTypecould get discarded when it is not marked as preserve literalscloses #2207