Skip to content

fix: fully unwrap union aliases in mapped keys to avoid generating incorrect additionalProperties #2232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: next
Choose a base branch
from
Open

fix: fully unwrap union aliases in mapped keys to avoid generating incorrect additionalProperties #2232

wants to merge 2 commits into from

Conversation

alexchexes
Copy link
Contributor

Closes #2231

arthurfiorette
arthurfiorette approved these changes Apr 14, 2025
View reviewed changes
Copy link
Collaborator

@arthurfiorette arthurfiorette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@domoritz domoritz domoritz left review comments

@arthurfiorette arthurfiorette arthurfiorette requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Pick with union of unions of literals generates wrong additionalProperties.
3 participants
@alexchexes @domoritz @arthurfiorette