Adjusted the menu item height which was off, changed font to use Zekton - #112
Open
SGD1953 wants to merge 1 commit into
Open
Adjusted the menu item height which was off, changed font to use Zekton#112SGD1953 wants to merge 1 commit into
SGD1953 wants to merge 1 commit into
Conversation
royfalk
self-requested a review
July 30, 2026 19:50
Contributor
|
I don't get it. What changed in menu.png? |
Author
|
@royfalk they do, but if you look closely, the right image menu items end a bit higher compared to the left. The font was slightly too large which made it unaligned with the click zones. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for previous main menu PR #110 which introduced a wrong element positioning which made the click areas being off so that quit was not working anymore as it was too far down.
The good news is, the
xcffile is now fully in line with the current game. It might make sense to add a layer with the actual click zones as rectangles so that this becomes a bit more visual