Fix comma locales (0.11.x), continued - #1683
Open
stephengtuggy wants to merge 3 commits into
Open
Conversation
…nclose interpolated CI variables in double quotes
stephengtuggy
marked this pull request as ready for review
August 4, 2026 01:59
stephengtuggy
requested review from
BenjamenMeyer,
evertvorster,
kheckwrecker and
royfalk
August 4, 2026 01:59
Contributor
Author
|
The unit tests are working again on macOS! For that reason alone, I would like to get this PR merged ASAP. But we'd better play-test it properly on as many supported OSes as possible before merging it. @royfalk can you play-test this on macOS? @kheckwrecker can you take Windows? If not, I might be able to take Windows instead, but it might take me a bit to get to it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for submitting a pull request and becoming a contributor to the Vega Strike Core Engine.
Please answer the following:
Code Changes:
Issues:
Purpose:
master(0.11.x) branch, among other things setting the Pythoncoerce_c_localesetting to a different value and in more places, and outputting to cout what encoding we find that works.