Skip to content

Fix comma locales (0.11.x), continued - #1683

Open
stephengtuggy wants to merge 3 commits into
vegastrike:masterfrom
stephengtuggy:fix/comma-locales-0.11.x-continued
Open

Fix comma locales (0.11.x), continued#1683
stephengtuggy wants to merge 3 commits into
vegastrike:masterfrom
stephengtuggy:fix/comma-locales-0.11.x-continued

Conversation

@stephengtuggy

Copy link
Copy Markdown
Contributor

Thank you for submitting a pull request and becoming a contributor to the Vega Strike Core Engine.

Please answer the following:

Code Changes:

Issues:

Purpose:

  • What is this pull request trying to do? Continue the locale-related fixes on the master (0.11.x) branch, among other things setting the Python coerce_c_locale setting to a different value and in more places, and outputting to cout what encoding we find that works.
  • What release is this for? 0.11.x
  • Is there a project or milestone we should apply this to? 0.11.x

@stephengtuggy stephengtuggy added this to the 0.11.x milestone Aug 1, 2026
@stephengtuggy stephengtuggy self-assigned this Aug 1, 2026
@stephengtuggy stephengtuggy added bug help wanted github_actions Pull requests that update GitHub Actions code labels Aug 1, 2026
@github-project-automation github-project-automation Bot moved this to Backlog in VS Engine Aug 1, 2026
@stephengtuggy stephengtuggy moved this from Backlog to In progress in VS Engine Aug 4, 2026
…nclose interpolated CI variables in double quotes
@stephengtuggy
stephengtuggy marked this pull request as ready for review August 4, 2026 01:59
@stephengtuggy stephengtuggy moved this from In progress to In review in VS Engine Aug 4, 2026
@stephengtuggy

Copy link
Copy Markdown
Contributor Author

The unit tests are working again on macOS! For that reason alone, I would like to get this PR merged ASAP. But we'd better play-test it properly on as many supported OSes as possible before merging it.

@royfalk can you play-test this on macOS? @kheckwrecker can you take Windows? If not, I might be able to take Windows instead, but it might take me a bit to get to it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug github_actions Pull requests that update GitHub Actions code help wanted

Projects

Status: In review

Development

Successfully merging this pull request may close these issues.

1 participant