Skip to content

Conversation

@thephluxer
Copy link
Contributor

I made some changes with features I wanted. Everything is optional and has to be enabled in the mod-settings.
The default behaviour of the mod is unchanged (except for the bugfix ofc).

  • Added option to auto start recordings with the main camera when starting a new game
  • Added option to auto create subdirectories named after the map seed to easily save screenshots for multiple save games
  • Added option to choose file format (png or jpg) to have an option with smaller file sizes
  • Fixed a bug that named screenshot files as "new-camera" when main camera was used

My intention with these changes was to make a more hand-off style of use possible.
I played a few hours without issue and tryed to test the changes to the best of my abilities.

Copy link
Owner

@veger veger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thank you for your contribution!

It looks nice when looking at the code changes, but I want to try it out in the game as well to double check.

Ideally, the features would have been in separate PRs, so they could be merged individually. But if you are willing to add (a) changelog entry(ies), I can squash merge this one also. Assuming my playtesting and/or more careful reviewing will not show issues. But this has to be done tomorrow, as it is pretty late already.

@thephluxer
Copy link
Contributor Author

Great! I'm happy you like it so far!

I added the changelog entry for my changes.

Comment on lines +170 to +171
savePath = string.format(
"%s/%s/%d/%010d-%s.%s",
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if we should store (cache) savePath in playerSettings...? 🤔

There are so many components to build the path and only the screenshotNumber is changing each save. All the others are static and only change when the player settings are changed.

Maybe it is better to cache this outside of playerSettings, as we then initialize on startup and do not require a migration to existing saves...

Copy link
Owner

@veger veger Feb 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll create a ticket for this, as it is a separate issue and should not be part of this PR.

Camera name is also part of it, so caching this properly requires more changes than I initially imagined...
It is probably not worth it (especially with the risk of forgetting of updating the cached path in some scenario).

@veger veger merged commit c939d28 into veger:master Feb 19, 2025
1 check passed
@veger
Copy link
Owner

veger commented Feb 19, 2025

Thanks again for your contribution!

I'll make a release this evening (maybe something pops up in my mind that needs changing 😉 )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants