550 fix bug with selected tab on page scroll #580
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
refactored home to not use shared layout for navtabs by adding a useLayoutEffect
run pnpm biome format --write src/routes/_home.tsx to fix formatting for a clean pnpm check
❌ Deploy Preview for vektorprogrammet-homepage failed.
|
|
perhsolheim
approved these changes
Feb 9, 2026
Contributor
perhsolheim
left a comment
perhsolheim
left a comment
There was a problem hiding this comment.
Looks good to me chief
Deploying homepage with
|
| Latest commit: |
d154fb9
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://721dece4.homepage-dl3.pages.dev |
| Branch Preview URL: | https://550-fix-bug-with-selected-ta.homepage-dl3.pages.dev |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request updates the navigation tab component in
src/routes/_home.tsxto improve the active tab indicator. Instead of each tab rendering its own indicator, a single animated indicator is now rendered based on the active route, resulting in smoother transitions and cleaner code. The implementation leverages React hooks and refs to track tab positions and animate the indicator.Navigation Tab Indicator Improvements:
motion.div, which smoothly transitions its position and width based on the active route. This replaces the previous approach where each tab rendered its own indicator.useLayoutEffect,useRef, anduseStateto track the position and width of the active tab and update the indicator accordingly.useLocationfromreact-routerto support the new indicator logic.