Update AzureAD Microsoft Authentication Library to v1.5.0#294
Open
priyansh17 wants to merge 3 commits intovelero-io:mainfrom
Open
Update AzureAD Microsoft Authentication Library to v1.5.0#294priyansh17 wants to merge 3 commits intovelero-io:mainfrom
priyansh17 wants to merge 3 commits intovelero-io:mainfrom
Conversation
Signed-off-by: Priyansh Choudhary <im1706@gmail.com>
Signed-off-by: Priyansh Choudhary <im1706@gmail.com>
kaovilai
previously approved these changes
Sep 11, 2025
shubham-pampattiwar
approved these changes
Sep 11, 2025
| require ( | ||
| github.com/Azure/azure-sdk-for-go/sdk/internal v1.11.1 // indirect | ||
| github.com/AzureAD/microsoft-authentication-library-for-go v1.4.2 // indirect | ||
| github.com/AzureAD/microsoft-authentication-library-for-go v1.5.0 // indirect |
Collaborator
There was a problem hiding this comment.
first do this in velero repo.
Collaborator
Author
There was a problem hiding this comment.
Merged velero-io/velero#9244 and updated package refernece.
shubham-pampattiwar
previously approved these changes
Sep 11, 2025
Signed-off-by: Priyansh Choudhary <im1706@gmail.com>
priyansh17
dismissed stale reviews from shubham-pampattiwar and kaovilai
via
698d488
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #294 +/- ##
=======================================
Coverage 18.78% 18.78%
=======================================
Files 4 4
Lines 527 527
=======================================
Hits 99 99
Misses 425 425
Partials 3 3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Collaborator
Author
|
@kaovilai / @shubham-pampattiwar I had updated the go package reference for velero from main branch, is that correct or do you guys update it from specific 1.16/1.17 branches? What I performed: |
Collaborator
|
For main I think this is fine. |
kaovilai
approved these changes
Sep 12, 2025
shubham-pampattiwar
approved these changes
Sep 12, 2025
Collaborator
Author
|
Hi @ywk253100, can we merge this? |
Collaborator
|
@blackpiglet any objections? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Priyansh Choudhary im1706@gmail.com
Fix for the bug introduced here where User is Unable to login to Azure China.
AzureAD/microsoft-authentication-library-for-go#574
Fixes #(issue)
velero-io/velero#9205