chore: enable early-return, if-return and superfluous-else from revive#8640
Closed
mmorel-35 wants to merge 1 commit into
Closed
chore: enable early-return, if-return and superfluous-else from revive#8640mmorel-35 wants to merge 1 commit into
mmorel-35 wants to merge 1 commit into
Conversation
Contributor
Author
|
/kind changelog-not-required |
76702e6 to
f01c93f
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #8640 +/- ##
==========================================
+ Coverage 59.67% 59.70% +0.03%
==========================================
Files 381 381
Lines 43879 43787 -92
==========================================
- Hits 26186 26145 -41
+ Misses 16147 16109 -38
+ Partials 1546 1533 -13 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
f01c93f to
7863522
Compare
blackpiglet
previously approved these changes
Feb 7, 2025
7863522 to
2973e3c
Compare
2973e3c to
7162b91
Compare
7162b91 to
a34576c
Compare
5abdf92 to
5a9fa67
Compare
8e897d4 to
a3ac48f
Compare
a3ac48f to
9fe6681
Compare
9fe6681 to
199870c
Compare
199870c to
c81b7a1
Compare
a962937 to
880bcb6
Compare
Contributor
Author
|
OK, I provided comments and links for each new rule |
kaovilai
previously approved these changes
Jun 23, 2025
880bcb6 to
573e47f
Compare
573e47f to
c15cea3
Compare
c15cea3 to
c9b0065
Compare
Collaborator
|
LGTM - purely stylistic linter refactoring with no logical changes. |
kaovilai
approved these changes
Jun 27, 2025
22ca2fa to
490bb4c
Compare
kaovilai
previously approved these changes
Jul 17, 2025
490bb4c to
cdc5fbd
Compare
kaovilai
approved these changes
Jul 18, 2025
c908ce9 to
11afa16
Compare
kaovilai
previously approved these changes
Jul 21, 2025
11afa16 to
178c3e1
Compare
44931c5 to
2960183
Compare
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
2960183 to
fc24af1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for contributing to Velero!
Please add a summary of your change
enables and fixes this rules from revive
Enable preserveScope for indent-error-flow to not suggest refactorings that would increase variable scope.
Does your change fix a particular issue?
Fixes #(issue)
Please indicate you've done the following:
make new-changelog) or comment/kind changelog-not-requiredon this PR.site/content/docs/main.