Skip to content

Support using image registry proxy in more cases.#8927

Merged
blackpiglet merged 1 commit into
velero-io:mainfrom
blackpiglet:modify_image_usage
May 14, 2025
Merged

Support using image registry proxy in more cases.#8927
blackpiglet merged 1 commit into
velero-io:mainfrom
blackpiglet:modify_image_usage

Conversation

@blackpiglet
Copy link
Copy Markdown
Contributor

@blackpiglet blackpiglet commented May 12, 2025

Thank you for contributing to Velero!

Please add a summary of your change

Does your change fix a particular issue?

Fixes #(issue)

Please indicate you've done the following:

@blackpiglet blackpiglet added the kind/changelog-not-required PR does not require a user changelog. Often for docs, website, or build changes label May 12, 2025
@codecov
Copy link
Copy Markdown

codecov Bot commented May 12, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.56%. Comparing base (d5a2e7e) to head (14e1055).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8927   +/-   ##
=======================================
  Coverage   59.56%   59.56%           
=======================================
  Files         370      370           
  Lines       40267    40267           
=======================================
  Hits        23987    23987           
  Misses      14778    14778           
  Partials     1502     1502           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@blackpiglet blackpiglet force-pushed the modify_image_usage branch 3 times, most recently from 060ec88 to d3b9781 Compare May 13, 2025 05:15
@blackpiglet blackpiglet marked this pull request as ready for review May 13, 2025 05:39
@github-actions github-actions Bot requested review from Lyndon-Li and reasonerjt May 13, 2025 05:39
@blackpiglet blackpiglet force-pushed the modify_image_usage branch 4 times, most recently from fd1bca3 to 704e04a Compare May 13, 2025 09:46
kaovilai
kaovilai previously approved these changes May 13, 2025
Copy link
Copy Markdown
Collaborator

@kaovilai kaovilai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

Notes

The removal of the useVolumeSnapshots parameter from the KibishiiPrepareBeforeBackup and installKibishii functions doesn't affect the functionality because:

  1. The parameter wasn't actually used within those functions.
  2. The parameter is still used in the RunKibishiiTests function where it's needed for the backup configuration and post-backup verification.

Signed-off-by: Xun Jiang <xun.jiang@broadcom.com>
@blackpiglet blackpiglet force-pushed the modify_image_usage branch from bedbbae to 14e1055 Compare May 14, 2025 00:47
@blackpiglet blackpiglet merged commit 5e92ca0 into velero-io:main May 14, 2025
46 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

has-e2e-2tests kind/changelog-not-required PR does not require a user changelog. Often for docs, website, or build changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants